Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagesize = all not woking on Archived Workflow View #3775

Closed
xinbinhuang opened this issue Aug 13, 2020 · 8 comments · Fixed by #3778 or #4486
Closed

Pagesize = all not woking on Archived Workflow View #3775

xinbinhuang opened this issue Aug 13, 2020 · 8 comments · Fixed by #3778 or #4486
Labels

Comments

@xinbinhuang
Copy link

xinbinhuang commented Aug 13, 2020

Summary

What happened/what you expected to happen?

In the Archived Workflow View, the default page size is 10 and it cannot be changed to all. I think it will be better to be consistent with the Timeline view: default all

Also, I feel like the Archived Workflow is somehow redundant to the Timeline View. I wonder what's the actual use case for it?

Diagnostics

What version of Argo Workflows are you running?

2.9.3


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@xinbinhuang xinbinhuang changed the title Incorrect (unreasonable) Phases filtering on Archived Workflow View Pagesize = all not woking on Archived Workflow View Aug 13, 2020
@alexec
Copy link
Contributor

alexec commented Aug 13, 2020

A default of all would crash the browser of users with many archived workflows. However, it should be possible to change to all. Can you confirm if you have had a problem with this?

@xinbinhuang
Copy link
Author

A default of all would crash the browser of users with many archived workflows. However, it should be possible to change to all. Can you confirm if you have had a problem with this?

I can change to 500 but not all..

@alexec
Copy link
Contributor

alexec commented Aug 14, 2020

I can change to 500 but not all..

Screenshot? Diagnostics?

@xinbinhuang
Copy link
Author

Here is the error
image

@alexec
Copy link
Contributor

alexec commented Sep 2, 2020

Available for testing in v2.11.0-rc1.

@claas-fridtjof-lisowski
Copy link

I'm still seeing this error in v2.11.1 when I choose to show "all" results

react-dom.production.min.js:198 TypeError: Cannot read property 'toString' of null
    at t.get (archived-workflow-list.tsx:126)
    at t.saveHistory (archived-workflow-list.tsx:132)
    at oa (react-dom.production.min.js:193)
    at ra (react-dom.production.min.js:193)
    at Ha (react-dom.production.min.js:216)
    at Va (react-dom.production.min.js:220)
    at react-dom.production.min.js:250
    at Object.t.unstable_runWithPriority (scheduler.production.min.js:18)
    at Ts (react-dom.production.min.js:250)
    at Es (react-dom.production.min.js:249)

@dcherman
Copy link
Member

dcherman commented Nov 6, 2020

@alexec Can we reopen this one? I'm running into this as well (essentially the same stacktrace).

The problem is here:

https://github.com/argoproj/argo/blob/a441a97bd53a92b8cc5fb918edd1f66701d1cf5c/ui/src/app/shared/components/pagination-panel.tsx#L38-L39

The value of all is piped through parseLimit, however parseLimit returns null for values that it's unable to parse.

That causes this line to throw:

https://github.com/argoproj/argo/blob/1cc68d8939a7e144a798687f6d8b8ecc8c0f4195/ui/src/app/archived-workflows/components/archived-workflow-list/archived-workflow-list.tsx#L126

I can fix this later today, just need to figure out what value the backend expects when the value should be all. If you happen to know that off the top of your head, that'd be very helpful

@alexec alexec reopened this Nov 6, 2020
@alexec
Copy link
Contributor

alexec commented Nov 6, 2020

I think all should mean we should not pass anything to the backend.

dcherman added a commit to dcherman/argo that referenced this issue Nov 7, 2020
Fixes argoproj#3775

Signed-off-by: Daniel Herman <dherman@factset.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants