-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to allow unsigned CA with SSO enabled #6793
Comments
We use You'll need to raise an issue with the upstream get this changed: |
Opened an issue there: |
You can configure go-oidc's HTTP client with ClientContext https://pkg.go.dev/github.com/coreos/go-oidc/v3/oidc#ClientContext (This is the same strategy that x/oauth2 uses) |
Thank you @ericchiang . Sounds like I was wrong. @sylock would you be interested in submitting a PR to fix this? |
@alexec Do you mean an empty PR so somebody else can take over it? (But I'm not sure how to create an empty PR). If not, I'm not a goland dev and I won't be able to fix this issue. Tell me how can I help (except dev). |
…#6961) Signed-off-by: Niclas Schnickmann <niclas.schnickmann@nextstep-services.de> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
…rgoproj#6978) Signed-off-by: Niclas Schnickmann <niclas.schnickmann@nextstep-services.de> Signed-off-by: kriti-sc <kathuriakriti1@gmail.com>
Did this change make into 3.2.3? I am getting the same error. Keycloak for OIDC , using mkcert for local certifcate
I have attached mkcert rootCA to argo-server which should do something similar to below.
|
@amit-va Based on the release changelogs and the v3.2.2 cherry pick it doesn't look like it has been in any of the releases yet. @alexec or someone more familiar with how this works could probably weigh in better here, |
If anyone wonders: This works now with v3.2.5 by adding
Big thank you from my side - argo is really an awesome project! |
I was looking for this a month ago and ended up mounting the ca.pem. But I can now confirm the solution as provided by @nterra-paul works! |
this parameter is not working in 3.4.2 |
Is there any new parameter replace it ? I also found that not worked. |
Summary
What happened/what you expected to happen?
I'm trying to configure SSO against an oauth 2 provider. That provider has an unsigned CA (this is a test environement). Argo server complains about it and refuse to start. I see that on dex you can set in the configmap the config "insecureCA: true" but I don't see such option neither in the workflow-controller-configmap or as an argument of the argo-server.
Can you help me?
What version of Argo Workflows are you running?
v3.1.3
Diagnostics
The logs of argo-server pod:
What Kubernetes provider are you using?
I'm using openshift:
Client Version: 4.8.11
Server Version: 4.7.7
Kubernetes Version: v1.20.0+c8905da
What executor are you running? Docker/K8SAPI/Kubelet/PNS/Emissary
PNS
Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.
The text was updated successfully, but these errors were encountered: