Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve taskset/HTTP template logging #7243

Closed
alexec opened this issue Nov 18, 2021 · 3 comments · Fixed by #7324
Closed

Improve taskset/HTTP template logging #7243

alexec opened this issue Nov 18, 2021 · 3 comments · Fixed by #7324
Assignees
Labels
good first issue Good for newcomers type/feature Feature request

Comments

@alexec
Copy link
Contributor

alexec commented Nov 18, 2021

A lot of the logging for taskset/http template logs the Go object, which results in log lines that are (a) not very human readable and (b) not very machine readable, therefore less helpful that they could be:

Example:

             controller | time="2021-11-17T18:01:51.237Z" level=debug msg="patching the exiting taskset" TaskSet="map[controller-plugin-template-qj4gt:{main {[] []} {[] [] <nil> <nil>} map[] nil {map[] map[]} <nil> [] nil nil nil nil nil nil nil nil 0xc0005b5308 [] [] [] nil <nil> nil <nil> <nil> []   <nil>  <nil> nil [] nil  nil nil nil }]" namespace=argo workflow=controller-plugin-template-qj4gt

We could log the JSON of the object, but that's not machine readable. Better to just be structured.

@alexec alexec added the type/feature Feature request label Nov 18, 2021
@alexec
Copy link
Contributor Author

alexec commented Nov 18, 2021

@sarabala1979 could ask you to own this please?

@sarabala1979
Copy link
Member

sarabala1979 commented Nov 18, 2021 via email

@sarabala1979 sarabala1979 self-assigned this Nov 22, 2021
@sarabala1979 sarabala1979 added the good first issue Good for newcomers label Nov 30, 2021
@sarabala1979 sarabala1979 removed their assignment Nov 30, 2021
@alexec alexec self-assigned this Dec 1, 2021
@alexec
Copy link
Contributor Author

alexec commented Dec 1, 2021

@sarabala1979 I'm going to pick this up:

  1. I have a clear idea of what changes I want
  2. It'll take about 1h for me to do.
  3. This is blocker for the plugins.

alexec added a commit to alexec/argo-workflows that referenced this issue Dec 1, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec added a commit that referenced this issue Dec 6, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@sarabala1979 sarabala1979 mentioned this issue Dec 15, 2021
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/feature Feature request
Projects
None yet
2 participants