Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Search by name for WorkflowTemplates in UI #11684

Merged
merged 12 commits into from
Sep 17, 2023
Merged

feat: Search by name for WorkflowTemplates in UI #11684

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
017d8a7
feat: Change client-side api to support searching by name workflowTem…
shmruin Aug 20, 2023
162be8b
feat: Add filtering by namePattern parameter to ListWorkflowTemplates
sunyeongchoi Aug 20, 2023
dbeeab5
feat: Add workflow-template Filter components
Leeeuijooo Aug 24, 2023
890d882
feat: Add new pagination logic
shmruin Aug 24, 2023
16c70d2
feat: pagintation by resourceVersion
sunyeongchoi Aug 26, 2023
0f2f21d
fix: namePattern caching logic update in frontend
sunyeongchoi Aug 27, 2023
afe6159
fix: resourceVersion pagination code refactoring
sunyeongchoi Aug 27, 2023
65448b2
fix: reset pagination offset when input filter onChange
sunyeongchoi Aug 27, 2023
f387879
fix: ui lint
sunyeongchoi Aug 28, 2023
e939bb8
feat: add explanation of namePattern filtering list logic
sunyeongchoi Aug 29, 2023
9652ee2
Merge remote-tracking branch 'upstream/master' into cherrypick/enhanc…
sunyeongchoi Sep 17, 2023
392222b
feat: stick with the native pagination when search functionality is n…
sunyeongchoi Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/openapi-spec/swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

143 changes: 97 additions & 46 deletions pkg/apiclient/workflowtemplate/workflow-template.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion pkg/apiclient/workflowtemplate/workflow-template.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@ message WorkflowTemplateGetRequest {

message WorkflowTemplateListRequest {
string namespace = 1;
k8s.io.apimachinery.pkg.apis.meta.v1.ListOptions listOptions = 2;
string namePattern = 2;
k8s.io.apimachinery.pkg.apis.meta.v1.ListOptions listOptions = 3;
Comment on lines -27 to +28
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing the tag numbers is apparently a breaking change in protobufs, see #13160 (comment) for more details.

}

message WorkflowTemplateUpdateRequest {
Expand Down
6 changes: 4 additions & 2 deletions sdks/java/client/docs/WorkflowTemplateServiceApi.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading