fix: Add missing 'archived' prop for ArtifactPanel component. Fixes #12331 #12397

Garett-MacGowan · 2023-12-22T04:18:05Z

Motivation

A missing archived prop in the UI's ArtifactPanel component was causing an improper URL to be used to fetch the artifact (assuming the workflow was archived).

Modifications

Added the missing archived prop to the ArtifactPanel component.

Verification

I added tests to the argo server test suite to account for the URL structure which was previously untested. I called this test GetArtifactByNodeID, in accordance with naming conventions in similar tests.

For the UI, I ran the TestArtifactServerArtifactPassing test (which contains the GetArtifactByNodeID test mentioned above) using:

make start UI=true PROFILE=postgres
make TestArtifactServerArtifactPassing

Once it completed, I manually verified that the artifact in the ArtifactPanel was downloadable.

(download button)

jmeridth · 2023-12-24T16:52:59Z

Screenshot example?

Garett-MacGowan · 2023-12-24T16:56:54Z

Screenshot example?

I'll provide it in a moment.

Garett-MacGowan · 2023-12-24T17:50:39Z

Screenshot example?

@jmeridth I added the screenshots.

…xes an issue where the UI returns an Internal Server Error. Fixes argoproj#12331 Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

Garett-MacGowan · 2024-01-04T02:20:15Z

@agilgur5 this is rebased and ready to go

agilgur5

Just have a small comment around test naming, but otherwise LGTM.

Great catch and thanks for the detailed fix!

agilgur5 · 2024-01-08T22:32:52Z

test/e2e/argo_server_test.go

@@ -1037,6 +1037,30 @@ spec:
 	})
 }

+func (s *ArgoServerSuite) TestArtifactServerArtifactPassing() {


I feel like we should specify that this checking Archived Workflows specifically, though I do see that some of the tests name it explicitly and others don't 😕

@agilgur5 I changed the name to TestArtifactServerArchivedWorkflow. Is this more along the lines of what you were thinking?

Works for me. Naming is hard, especially for this level of specificity 😅

agilgur5 · 2024-01-08T22:35:21Z

Also is there a reason you merge main frequently in this PR? We don't require that PRs be up-to-date with main so it's not necessary. For most PRs, it usually doesn't affect anything either.

agilgur5 · 2024-01-08T22:39:21Z

Btw @Garett-MacGowan would you be interested in joining the Argo project as a Member?
You've had some great fixes along with very high quality PRs etc and we'd love to have you if you're interested. I would be willing to sponsor and I think Julie and others would as well 🙂

Garett-MacGowan · 2024-01-09T00:10:13Z

Btw @Garett-MacGowan would you be interested in joining the Argo project as a Member? You've had some great fixes along with very high quality PRs etc and we'd love to have you if you're interested. I would be willing to sponsor and I think Julie and others would as well 🙂

@agilgur5 I'd be happy to! There's no strict hourly commitment right? I'd be happy to spend a few hours every week.

Garett-MacGowan · 2024-01-09T00:12:12Z

Also is there a reason you merge main frequently in this PR? We don't require that PRs be up-to-date with main so it's not necessary. For most PRs, it usually doesn't affect anything either.

Didn't know PRs didn't need to be up to date. If there are conflicts, it would provide a different prompt than "Update branch" right?

…chivedWorkflow for clarity. Addresses PR comment. Fixes argoproj#12331 Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

agilgur5 · 2024-01-09T01:29:12Z

Didn't know PRs didn't need to be up to date.

It is a requirement you can add on GitHub, but we don't currently require it. There's only been a handful of times where that's caused an issue, which is actually with "invisible" merge conflicts (i.e. two PRs that when merged together break a build, but do not conflict in version control itself). I think we can also solve those with a merge queue as well instead of an extra PR requirement, as was discussed briefly over Slack

If there are conflicts, it would provide a different prompt than "Update branch" right?

Yep, it would say merging is not possible due to conflicts. The prompt instead says "Resolve conflicts" in that case.

agilgur5 · 2024-01-09T02:39:26Z

@agilgur5 I'd be happy to! There's no strict hourly commitment right? I'd be happy to spend a few hours every week.

Awesome! Correct, there are currently no strict commitments associated with Membership or other roles. It comes with some additional privileges (i.e. issue triage) and some small responsibilities that are usually the norm for active contributors in most repos anyway (e.g. responding when tagged). Otherwise, the only main "rule" outlined in the doc is that Members with no activity what-so-ever for an entire year will get pruned (but can still re-request whenever and will be expedited if so).

Could you file a membership request issue in the argoproj repo as is described in the above doc?
Julie upvoted my comment so can list both of us as sponsors and I'm pretty sure the Leads would be glad to sponsor as well once they see the request 🙂

We do also have a separate Sustainability Effort that was recently created that is specific to Argo Workflows (i.e. does not apply to CD or other projects at this time). That effort is a completely optional addition to the formal Argo project roles. If you're interested in that as well, that does have an hourly commitment but is not "strict" per se, as it is an average over time (e.g. I had 0 hours some weeks in Nov/Dec but my average is much higher).

agilgur5

LGTM

Garett-MacGowan · 2024-01-12T06:16:54Z

@agilgur5, @juliev0 can this be merged? It's unfortunate it didn't make it into the latest release.

agilgur5 · 2024-01-12T17:09:31Z

For reference, I'm not an Approver (yet), so I don't have merge permissions, which is why I requested a review from Julie.

Agreed this would have been good to have for the release, but we'll have another soon enough since there are still two P1 bugs out.

juliev0 · 2024-01-12T17:25:03Z

For reference, I'm not an Approver (yet), so I don't have merge permissions, which is why I requested a review from Julie.

Sorry, I missed that you requested my review!

Garett-MacGowan · 2024-01-12T17:43:11Z

Thanks Julie!

…12331 (#12397) Signed-off-by: Garett MacGowan <garettsoftware@gmail.com> Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>

…rgoproj#12331 (argoproj#12397) Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

…rgoproj#12331 (argoproj#12397) Signed-off-by: Garett MacGowan <garettsoftware@gmail.com> Signed-off-by: Isitha Subasinghe <isubasinghe@student.unimelb.edu.au>

jmeridth mentioned this pull request Dec 24, 2023

3.5 ListWorkflows causes server to hang when there are lots of archived workflows #12025

Closed

3 tasks

Garett-MacGowan mentioned this pull request Dec 24, 2023

fix: fix missing artifacts for stopped workflows. Fixes #12401 #12402

Merged

agilgur5 self-assigned this Dec 28, 2023

agilgur5 added area/ui area/artifacts S3/GCP/OSS/Git/HDFS etc area/server labels Dec 28, 2023

Garett-MacGowan added 2 commits January 3, 2024 16:58

fix: Add missing 'archived' prop for ArtifactPanel component. This fi…

cdc2772

…xes an issue where the UI returns an Internal Server Error. Fixes argoproj#12331 Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

fix: Empty commit for CI resubmit. Fixes: 12331

f4405b0

Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

Garett-MacGowan force-pushed the fix/archived_workflow_artifact branch from c8799f2 to f4405b0 Compare January 3, 2024 21:58

Garett-MacGowan added 3 commits January 3, 2024 19:48

fix: Empty commit for transient test failure. Fixes argoproj#12331

d698c6d

Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

fix: Empty commit for transient test failure. Fixes argoproj#12331

3c6b2a9

Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

fix: Empty commit for transient test failure. Fixes argoproj#12331

e3bfdff

Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

Garett-MacGowan added 5 commits January 4, 2024 08:13

Merge branch 'main' into fix/archived_workflow_artifact

ffd3a88

Merge branch 'main' into fix/archived_workflow_artifact

3cc01ee

Merge branch 'main' into fix/archived_workflow_artifact

e3d6f9c

Merge branch 'main' into fix/archived_workflow_artifact

7673065

Merge branch 'main' into fix/archived_workflow_artifact

a356b60

agilgur5 approved these changes Jan 8, 2024

View reviewed changes

agilgur5 requested a review from juliev0 January 8, 2024 22:33

Garett-MacGowan and others added 2 commits January 8, 2024 19:18

Merge branch 'argoproj:main' into fix/archived_workflow_artifact

e7ac081

fix: Rename TestArtifactServerArtifactPassing to TestArtifactServerAr…

565c14c

…chivedWorkflow for clarity. Addresses PR comment. Fixes argoproj#12331 Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

agilgur5 approved these changes Jan 9, 2024

View reviewed changes

Garett-MacGowan mentioned this pull request Jan 9, 2024

REQUEST: New membership for @Garett-MacGowan argoproj/argoproj#269

Closed

5 tasks

juliev0 approved these changes Jan 12, 2024

View reviewed changes

juliev0 merged commit b447951 into argoproj:main Jan 12, 2024
27 checks passed

This was referenced Jan 12, 2024

Release v3.4 patch releases discussion #11851

Open

Release v3.5 patch releases discussion #11997

Open

agilgur5 added the area/workflow-archive label Jan 14, 2024

agilgur5 mentioned this pull request Jan 30, 2024

Unable to download Artifacts from the Archived Workflows UI (v3.4.3) #9968

Closed

3 tasks

agilgur5 mentioned this pull request Feb 20, 2024

Unable to view artifacts of archived workflows in Workflows UI (v3.5.4) #12687

Closed

4 tasks

isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024

fix: Add missing 'archived' prop for ArtifactPanel component. Fixes a…

ed62f1f

…rgoproj#12331 (argoproj#12397) Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024

fix: Add missing 'archived' prop for ArtifactPanel component. Fixes a…

134865f

…rgoproj#12331 (argoproj#12397) Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request Feb 27, 2024

fix: Add missing 'archived' prop for ArtifactPanel component. Fixes a…

b2b4de3

…rgoproj#12331 (argoproj#12397) Signed-off-by: Garett MacGowan <garettsoftware@gmail.com>

agilgur5 mentioned this pull request Apr 12, 2024

feat: Unified workflows list UI and API #11121

Merged

agilgur5 added this to the v3.5.x patches milestone Apr 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add missing 'archived' prop for ArtifactPanel component. Fixes #12331 #12397

fix: Add missing 'archived' prop for ArtifactPanel component. Fixes #12331 #12397

Garett-MacGowan commented Dec 22, 2023 •

edited

Loading

jmeridth commented Dec 24, 2023

Garett-MacGowan commented Dec 24, 2023

Garett-MacGowan commented Dec 24, 2023

Garett-MacGowan commented Jan 4, 2024

agilgur5 left a comment

agilgur5 Jan 8, 2024

Garett-MacGowan Jan 9, 2024

Garett-MacGowan Jan 9, 2024

agilgur5 Jan 9, 2024

agilgur5 commented Jan 8, 2024

agilgur5 commented Jan 8, 2024

Garett-MacGowan commented Jan 9, 2024 •

edited

Loading

Garett-MacGowan commented Jan 9, 2024

agilgur5 commented Jan 9, 2024 •

edited

Loading

agilgur5 commented Jan 9, 2024 •

edited

Loading

agilgur5 left a comment

Garett-MacGowan commented Jan 12, 2024

agilgur5 commented Jan 12, 2024 •

edited

Loading

juliev0 commented Jan 12, 2024 •

edited by agilgur5

Loading

Garett-MacGowan commented Jan 12, 2024 •

edited by agilgur5

Loading

fix: Add missing 'archived' prop for ArtifactPanel component. Fixes #12331 #12397

fix: Add missing 'archived' prop for ArtifactPanel component. Fixes #12331 #12397

Conversation

Garett-MacGowan commented Dec 22, 2023 • edited Loading

Motivation

Modifications

Verification

jmeridth commented Dec 24, 2023

Garett-MacGowan commented Dec 24, 2023

Garett-MacGowan commented Dec 24, 2023

Garett-MacGowan commented Jan 4, 2024

agilgur5 left a comment

Choose a reason for hiding this comment

agilgur5 Jan 8, 2024

Choose a reason for hiding this comment

Garett-MacGowan Jan 9, 2024

Choose a reason for hiding this comment

Garett-MacGowan Jan 9, 2024

Choose a reason for hiding this comment

agilgur5 Jan 9, 2024

Choose a reason for hiding this comment

agilgur5 commented Jan 8, 2024

agilgur5 commented Jan 8, 2024

Garett-MacGowan commented Jan 9, 2024 • edited Loading

Garett-MacGowan commented Jan 9, 2024

agilgur5 commented Jan 9, 2024 • edited Loading

agilgur5 commented Jan 9, 2024 • edited Loading

agilgur5 left a comment

Choose a reason for hiding this comment

Garett-MacGowan commented Jan 12, 2024

agilgur5 commented Jan 12, 2024 • edited Loading

juliev0 commented Jan 12, 2024 • edited by agilgur5 Loading

Garett-MacGowan commented Jan 12, 2024 • edited by agilgur5 Loading

Garett-MacGowan commented Dec 22, 2023 •

edited

Loading

Garett-MacGowan commented Jan 9, 2024 •

edited

Loading

agilgur5 commented Jan 9, 2024 •

edited

Loading

agilgur5 commented Jan 9, 2024 •

edited

Loading

agilgur5 commented Jan 12, 2024 •

edited

Loading

juliev0 commented Jan 12, 2024 •

edited by agilgur5

Loading

Garett-MacGowan commented Jan 12, 2024 •

edited by agilgur5

Loading