fix: custom columns not supporting annotations #12421
Merged
Commits on Dec 29, 2023
-
fix: custom columns not supporting annotations
- [x] search annotations for matching key from user's custom column type - docs state we can use labels and annotations [here](https://github.com/argoproj/argo-workflows/blob/954884d64c7b2d24a2e5fa0641a66692d182fefd/pkg/apis/workflow/v1alpha1/info.go#L21) and [here](https://github.com/argoproj/argo-workflows/blob/954884d64c7b2d24a2e5fa0641a66692d182fefd/docs/workflow-controller-configmap.yaml#L90) Signed-off-by: jmeridth <jmeridth@gmail.com> Co-authored-by: Steven Johnson <52087249+stevenbjohnson@users.noreply.github.com>
-
Update ui/src/app/workflows/components/workflows-row/workflows-row.tsx
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Signed-off-by: Jason Meridth <jmeridth@gmail.com>
-
fix: single quotes instead of double quotes on string comparison
Signed-off-by: jmeridth <jmeridth@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.