-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: consistently use "> v{version} and after" #12581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- some said "since" or "and above", while most said "and after" - "above" is a SemVer ref, whereas "after" is a date ref, so I think the latter is easier to interpret - nbd either way IMO, but be consistent - some just had the version without saying "and after" or similar - it is clearer to say "and after" - and most have it, so be consistent - some were missing the "v" in front of the version - again, be consistent (especially since the "v" does in fact matter for referencing tags) - two were in the wrong place, above the heading instead of below the heading - fix doubled `>` on an empty line misc changes that were right next to the versions: - fix typo "The submit a" -> "Then submit a" - use a material warning box instead of a unicode caution sign - link to official k8s docs regarding HA and multi-AZs - anti-affinity is not the only way to do this now, and topology spread constraints is perhaps a better / newer way of doing it - also, in general, prefer official docs links over blog posts Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
jmeridth
approved these changes
Jan 28, 2024
juliev0
approved these changes
Feb 17, 2024
This was referenced Feb 18, 2024
agilgur5
added a commit
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
This was referenced May 29, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
some said "since" or "and above", while most said "and after"
some just had the version without saying "and after" or similar
some were missing the "v" in front of the version
git
or Docker / OCI)two were in the wrong place, above the heading instead of below the heading
Modifications
>
on an empty linemisc changes that were right next to the versions:
Verification
docs/
directory with "> "make docs
passes