-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(build): uname
handling for mac M1 arch. Fixes #13112
#13113
Conversation
Signed-off-by: Adrien Delannoy <a.delannoyfr@gmail.com>
uname
handling for mac M1 arch. Fixes #13112
Follow-up to #12754 |
Signed-off-by: Adrien Delannoy <a.delannoyfr@gmail.com>
Signed-off-by: Adrien Delannoy <a.delannoyfr@gmail.com>
@agilgur5 I implemented your last option as it looks way nicer Also I was facing an issue running
|
Yea I got the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, thanks for the fixes
Ah hitting the DCO issue dcoapp/app#211; it was just resolved, needs a new commit to re-trigger |
Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Fixes #13112
Motivation
Unable to build the project using
make start UI=true
, and fails because of my M1 archModifications
I updated the
TARGET_PLATFORM
value on the Makefile to be able to also handle my arch value which isaarch64
Verification