fix(test): load to stream tmp file counting #13366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/tech-debt
area/artifacts
agilgur5
reviewed
Jul 19, 2024
The current test counts files in /tmp and hopes there are the same number before and after the test, which is fragile Add a prefix to the stream temporary files. Only count files in /tmp which have this prefix. Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
force-pushed
the
fix-test-load-to-stream-fs-race
branch
from
3258dff
to
7f545ac
Compare
Joibel
added a commit
to pipekit/argo-workflows
that referenced
this pull request
Sep 19, 2024
Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
added a commit
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Alan Clucas <alan@clucas.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #13037
Motivation
This test has an infrequent flake, see #13037
Modifications
The current test counts files in
/tmpand hopes there are the same number before and after the test, which is fragileAdd a prefix to the stream temporary files.
Only count files in
/tmpwhich have this prefix.Verification
Tested locally. Tested with a file called
/tmp/wfstream-asdfasdand extra logging in the test to show the numbers are as expected.Tested with the
os.Remove()removed fromselfDestructingFile.Close()to show failure.