-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(devcontainer): chown
regression for make codegen
#13375
Conversation
argoproj#13348 removed a recursive flag from chown. I believe this is because this is slow on poorly performing filesystems. This breaks codegen with ``` fatal: could not create leading directories of '/home/vscode/go/src/github.com/gogo/protobuf': Permission denied ``` This is a smarter recursive chown which fixes the issue for me. Signed-off-by: Alan Clucas <alan@clucas.org>
It worked in my development environment. |
The fix works, to clarify |
make codegen
chown
regression in make codegen
chown
regression in make codegen
chown
regression for make codegen
Dang, can confirm it does this in my devcontainer too. This might be due to similar reasons as #13145 that codegen didn't run. Thank you both for catching this!
Atrociously slow -- many minutes, I don't think I've ever once waited till the end, I have no idea how long it could take total. Since it worked fine even with me cancelling part-way, something about it isn't entirely necessary. From a quick trace, it does seem like a lot of time is spent on the |
these 3 seem to be the necessary ones Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
I'm not saying it's mac specific, but either APFS or the docker desktop virtualisation through to APFS is causing slowdown. The writes are happening in the docker overlay, but they presumably have to thunk through to understand the underlying files. On Linux with the source files on ext4 and using btrfs as the docker storage driver this takes less than 2 seconds. When I wrote this chown originally I wasn't using btrfs, just overlay2, and it was a much slower computer, and it was still unnoticable as a part of startup. |
Presumably, although something feels off that other FS commands aren't similarly slow I'm curious if someone else has the same issue on Mac? Did Adrien have it too? Although if these 3 directories are enough, then we won't need to worry about it either way (although it is possible another FS-type issue could crop up again with the devcontainer in the future)
The other outlier is that my |
Signed-off-by: Alan Clucas <alan@clucas.org> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com> Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
#13348 removed a recursive flag from chown. I believe was done because this is slow on macintosh filesystems.
This breaks codegen with
This is a smaller recursive chown which fixes the issue for me.