Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test k8s version 1.28 and 1.30 #13381

Merged
merged 3 commits into from
Jul 27, 2024
Merged

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Jul 22, 2024

Motivation

Modifications

  • added test coverage for 1.30 and 1.28
  • dropped coverage for 1.26

Verification

e2e tests

blkperl and others added 3 commits July 22, 2024 16:49
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
@blkperl blkperl marked this pull request as ready for review July 23, 2024 05:37
@blkperl blkperl added the type/dependencies PRs and issues specific to updating dependencies label Jul 23, 2024
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 27, 2024
@terrytangyuan terrytangyuan merged commit c757a31 into argoproj:main Jul 27, 2024
28 checks passed
| **3.3** | `?` | `?` | `?` | `?` | `?` |
| Argo Workflows \ Kubernetes | 1.28 | 1.29 | 1.30 |
|-----------------------------|------|------|------|
| **3.5** | `✓` | `✓` | `✓` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm I wonder if we should be changing this table given that we're not backporting these changes

@agilgur5 agilgur5 added area/build Build or GithubAction/CI issues and removed type/dependencies PRs and issues specific to updating dependencies labels Sep 15, 2024
@agilgur5 agilgur5 added this to the v3.6.0 milestone Sep 15, 2024
@blkperl blkperl deleted the ci_1.30 branch September 16, 2024 16:40
Joibel pushed a commit to pipekit/argo-workflows that referenced this pull request Sep 19, 2024
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
Joibel pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues lgtm This PR has been approved by a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants