Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: properly rename MustUnmarshalClusterWorkflowTemplate #13431

Merged

Conversation

qingfeng777
Copy link
Contributor

@qingfeng777 qingfeng777 commented Aug 3, 2024

Motivation

Fix the name of the function, to get better readability.

Modifications

rename function MustUnmarshalClusterWorkflow -> MustUnmarshalClusterWorkflowTemplate

Verification

ran locally

…wTemplate` function.

Signed-off-by: qingfeng777 <251098199@qq.com>
@qingfeng777 qingfeng777 marked this pull request as ready for review August 3, 2024 16:37
@agilgur5 agilgur5 changed the title refactor(apis): fix the function name of MustUnmarshalClusterWorkflowTemplate chore: properly rename MustUnmarshalClusterWorkflowTemplate Aug 3, 2024
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

@agilgur5 agilgur5 merged commit b6d6403 into argoproj:main Aug 3, 2024
30 checks passed
@qingfeng777 qingfeng777 deleted the api-refactor-unmarshel-cwftmpl-name branch August 4, 2024 02:44
Joibel pushed a commit to pipekit/argo-workflows that referenced this pull request Sep 19, 2024
Joibel pushed a commit that referenced this pull request Sep 20, 2024
Signed-off-by: qingfeng777 <251098199@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants