feat(ui): add history to WorkflowTemplate & ClusterWorkflowTemplate details #13452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panicboat
force-pushed
the
panicboat/add-details-list
branch
2 times, most recently
from
9c7ffce
to
e00afbf
Compare
panicboat
changed the title
Signed-off-by: panicboat <panicboat@gmail.com>
panicboat
force-pushed
the
panicboat/add-details-list
branch
from
e00afbf
to
301db1d
Compare
3 tasks
agilgur5
changed the title
agilgur5
reviewed
Aug 14, 2024
There was a problem hiding this comment.
This looks much better and simpler.
I left one correction of a comment below. The other comments are more for future consideration.
Otherwise LGTM, nice work 🙂
ui/src/app/workflows/components/workflow-details-list/workflow-details-list.tsx
Outdated
Show resolved
Hide resolved
ui/src/app/workflows/components/workflow-details-list/workflow-details-list.tsx
Show resolved
Hide resolved
| setWorkflows(workflowList.items); | ||
| setColumns(workflowsInfo.columns); | ||
| })(); | ||
| }, []); |
There was a problem hiding this comment.
we may want to consider adding name as a hook dep in the array here, but this is identical to cron-workflow-details.tsx right now, so this is fine.
ui/src/app/cluster-workflow-templates/cluster-workflow-template-details.tsx
Show resolved
Hide resolved
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13282
I didn't have the authority to reopen the #13283, so I am creating a new one.
Motivation
As indicated in the Issue, it is inconvenient that the history is not visible in the WorkflowTemplate details.
CronWorkflow can see it, so I would like to see consistency.
Modifications
WorkflowTemplate
No history
ClusterWorkflowTemplate
No history
Verification