Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe id in node field selector #13463

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Aug 13, 2024

This field was added in #6885 but is not in the documentation as noted

I opted to keep this an opaque value and not document the relationship with name as that is an internal detail that users should not rely on.

@Joibel Joibel changed the title docs: document id in node field selector docs: document id in node field selector Aug 13, 2024
@Joibel Joibel marked this pull request as ready for review August 13, 2024 13:50
@Joibel Joibel enabled auto-merge (squash) August 13, 2024 13:50
@agilgur5 agilgur5 changed the title docs: document id in node field selector docs: describe id in node field selector Aug 13, 2024
@agilgur5 agilgur5 added area/api Argo Server API area/docs Incorrect, missing, or mistakes in docs labels Aug 13, 2024
This field was added in argoproj#6885 but is not in the documentation

Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel merged commit 4728856 into argoproj:main Aug 19, 2024
16 checks passed
Joibel added a commit to pipekit/argo-workflows that referenced this pull request Sep 19, 2024
Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel added a commit that referenced this pull request Sep 20, 2024
Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel deleted the docs-nodeselector-id branch October 2, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Argo Server API area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants