Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): bump Pending to 100Tb of RAM #13606

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

Joibel
Copy link
Member

@Joibel Joibel commented Sep 16, 2024

This test should create an always Pending pod, but a cluster autoscaler may think it's helping and fulfill the request, making the test fail expensively. Hopefully it can't buy 100Tb of RAM nodes, so bump it to that.

This test should create an always `Pending` pod, but a cluster
autoscaler may think it's helping and fulfill the request, making the
test fail expensively. Hopefully it can't buy 100Tb of RAM nodes, so
bump it to that.

Signed-off-by: Alan Clucas <alan@clucas.org>
@Joibel Joibel marked this pull request as ready for review September 16, 2024 10:04
@Joibel Joibel added the area/build Build or GithubAction/CI issues label Sep 16, 2024
@terrytangyuan terrytangyuan merged commit 29ea351 into argoproj:main Sep 16, 2024
27 checks passed
@agilgur5 agilgur5 changed the title fix(test): it is possible to get 1Tb of RAM on a node fix(test): bump Pending to 100Tb of RAM Sep 17, 2024
@Joibel Joibel deleted the test-fix-pending-memory branch September 17, 2024 07:24
Joibel added a commit to pipekit/argo-workflows that referenced this pull request Sep 19, 2024
Joibel added a commit that referenced this pull request Sep 20, 2024
Signed-off-by: Alan Clucas <alan@clucas.org>
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Build or GithubAction/CI issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants