-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix workflow level timeouts #1369
Conversation
Jialu Zhu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
I agree with @dtaniwaki comments. @zhujl1991 - If those are addressed we can merge it in. |
Is it possible that the same issue breaks termination when retry is used? #1620 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I please request the following?
- Please sync with master and make sure all checks are green.
- Address any review comments.
23356d7
to
7298afd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1369 +/- ##
=========================================
+ Coverage 8.87% 8.88% +<.01%
=========================================
Files 53 53
Lines 33650 33662 +12
=========================================
+ Hits 2986 2990 +4
- Misses 30273 30280 +7
- Partials 391 392 +1
Continue to review full report at Codecov.
|
@alexec Is the e2e test flaky? https://github.com/argoproj/argo/pull/1369/commits we can see from here my commit 6f1e00f passed the e2e test while my latest one failed. But the only diff between the two commits is the revert of Gopkg.lock file. |
Hmm... Looks like the e2e test passed somehow. It was failed just now. |
e2e tests are not 100% stable yet |
issue: #848
mimic 133a23c . Set the pod ttl to template or wf ttl whichever is smaller.