fix(test): use different URL for http example test
#13737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <alan@clucas.org>
terrytangyuan
approved these changes
Oct 10, 2024
MasonM
approved these changes
Oct 10, 2024
agilgur5
changed the title
http example test
isubasinghe
pushed a commit
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Alan Clucas <alan@clucas.org>
isubasinghe
pushed a commit
that referenced
this pull request
Oct 30, 2024
Signed-off-by: Alan Clucas <alan@clucas.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The http-template example is tested as part of the examples suite.
examplefolder tests have a timeout of 30 seconds.This test attempts to get from a currently offline source of
http://openlibrary.org. It is supposed to fail to retrieve, but because the site is offline the test times out before the http GET times out, so the test fails.See this at https://github.com/argoproj/argo-workflows/actions/runs/11275007994/job/31355710660
Modifications
Modify the URL to use the successful server, which is also github so likely to be up if CI is running. Just modify the path to be invalid, so the expected outcome of a "fail to GET" is honoured.
Verification
Tested locally