docs: add 3.6 upgrading notes for postgres archive and ARGO_TEMPLATE
#13803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alan Clucas <alan@clucas.org>
Joibel
changed the title
ARGO_TEMPLATE)
agilgur5
changed the title
ARGO_TEMPLATE)ARGO_TEMPLATE
agilgur5
reviewed
Oct 24, 2024
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| > v2.5 and after | |||
|
|
|||
| If you want to keep completed workflows for a long time, you can use the workflow archive to save them in a Postgres or MySQL (>= 5.7.8) database. | |||
| If you want to keep completed workflows for a long time, you can use the workflow archive to save them in a Postgres (>=9.4) or MySQL (>= 5.7.8) database. | |||
There was a problem hiding this comment.
Thanks for adding this 👍 . I mentioned this part of the docs in #13295 (comment) et al too
There was a problem hiding this comment.
It might be good to add an optional Job to the Helm Charts or within the CLI or manifests that tests for compatibility before a deployment -- i.e. min postgres, mysql, and k8s versions as all the external deps. We had these kinds of "compatibility tests" this for many flexible charts we had at my last job (esp for things that often version conflicted, like Kubeflow's deps on older Argo or older Istio)
Comment on lines
+107
to
+108
| The environment variable `ARGO_TEMPLATE` which is an internal implementation detail is no longer available inside the `main` container of your workflow pods. | ||
| This is documented here as we are aware that some users of Argo Workflows use this. |
There was a problem hiding this comment.
Suggested change
| The environment variable `ARGO_TEMPLATE` which is an internal implementation detail is no longer available inside the `main` container of your workflow pods. | |
| This is documented here as we are aware that some users of Argo Workflows use this. | |
| The environment variable `ARGO_TEMPLATE` is no longer available inside the `main` container of your workflow pods. | |
| This is an internal implementation detail, but is documented here as we are aware that some Argo users have utilized this. |
- Clarify by modifying the sentence structure a bit - 1 sentence for the change, the other sentence for the internal piece
- also, without commas surrounding it, "which is an internal implementation detail" is grammatically incorrect
- The docs conventionally refer to "Argo Workflows" as "Argo", which I've noted in various places elsewhere too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds documentation for the breaking changes in #13779 and #13761