Code

Small code cleanup and add tests#1562

Code

Merged

jessesuen merged 11 commits intoargoproj:masterargoproj/argo-workflows:masterfrom AnesBenmerzoug:cleanup-and-testAnesBenmerzoug/argo:cleanup-and-testCopy head branch name to clipboardSep 21, 2019

+228-79

Commits

Commits on Aug 23, 2019

• Factor out the common code for reading manifest files in submit and template create

  AnesBenmerzoug

  committed
  210041d

• Handle reading from stdin in a separate case

  AnesBenmerzoug

  committed
  ae7f178

• Add tests for reading from file paths or urls

  AnesBenmerzoug

  committed
  5424f6c

• Fix test function description

  AnesBenmerzoug

  committed
  74d7c9d

• Fix variable scope

  AnesBenmerzoug

  committed
  738ea4e

• Put dry-run before server-dry-run

  AnesBenmerzoug

  committed
  addf17f

• Add test for dry-run option of workflow submit command

  AnesBenmerzoug

  committed
  d289d19

• Add a ReadFromStdin function to reduce code duplication

  AnesBenmerzoug

  committed
  d743a62

• Move the read functions to the end of the file

  AnesBenmerzoug

  committed
  f3d987d

• Add a ReadManifests function

  AnesBenmerzoug

  committed
  0f1ed3e

• Remove second definition of err variable

  AnesBenmerzoug

  committed
  73aeff7