Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Protobuf extension #1601

Merged
merged 11 commits into from
Nov 1, 2019
Merged

Conversation

sarabala1979
Copy link
Member

No description provided.

@xianlubird
Copy link
Member

Does this affect our compatibility?

@sarabala1979
Copy link
Member Author

Does this affect our compatibility?
No
This feature is for Argo API server. This PR will get merge after 2.4 release.

Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes but otherwise LGTM

#collect_swagger server 21
#clean_swagger server
#clean_swagger reposerver
#clean_swagger controller
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete all the unused code

workflow/validate/validate.go Show resolved Hide resolved
pkg/apis/workflow/v1alpha1/workflow_types.go Outdated Show resolved Hide resolved
pkg/apis/workflow/v1alpha1/workflow_types.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants