Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bugs in demo #1700

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Fixes bugs in demo #1700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcc91da
Fixes bugs in demo
simster7 Oct 21, 2019
74fc332
Update demo.md
simster7 Oct 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions demo.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@ kubectl create clusterrolebinding YOURNAME-cluster-admin-binding --clusterrole=c

To run all of the examples in this guide, the 'default' service account is too limited to support
features such as artifacts, outputs, access to secrets, etc... For demo purposes, run the following
command to grant admin privileges to the 'default' service account in the namespace 'default':
command to grant admin privileges to the 'default' service account in the namespace 'default'. Make sure you are on the 'default' namespace before running them.
```
kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=argo:default
kubectl create rolebinding default-admin --clusterrole=admin --serviceaccount=default:default
```
For the bare minimum set of privileges which a workflow needs to function, see
[Workflow RBAC](docs/workflow-rbac.md). You can also submit workflows which run with a different
Expand All @@ -60,6 +60,8 @@ argo get xxx-workflow-name-xxx
argo logs xxx-pod-name-xxx #from get command above
```

Make sure you run these examples while on the `default` namespace (since we granted admin privileges only within `default` on the previous step).

You can also create workflows directly with kubectl. However, the Argo CLI offers extra features
that kubectl does not, such as YAML validation, workflow visualization, parameter passing, retries
and resubmits, suspend and resume, and more.
Expand Down Expand Up @@ -90,7 +92,7 @@ helm install stable/minio \

Login to the Minio UI using a web browser (port 9000) after exposing obtaining the external IP using `kubectl`.
```
kubectl get service argo-artifacts -o wide
kubectl -n argo get service argo-artifacts -o wide
```
On Minikube:
```
Expand Down