Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gonum.org/v1/gonum/graph to Gopkg.toml #1726

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Add gonum.org/v1/gonum/graph to Gopkg.toml #1726

merged 2 commits into from
Nov 1, 2019

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Nov 1, 2019

After adding protobuf functionality make codegen now requires gonum.org/v1/gonum/graph. However, it wasn't added to Gopkg.toml so running dep ensure wouldn't fetch it. Added under required per the dep docs.

@simster7 simster7 requested a review from sarabala1979 November 1, 2019 18:08
sarabala1979
sarabala1979 requested changes Nov 1, 2019
View reviewed changes
Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think , is missing at end

@simster7 simster7 merged commit 12b983f into argoproj:master Nov 1, 2019
@simster7 simster7 deleted the dep-proto branch November 1, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarabala1979 sarabala1979 sarabala1979 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simster7 @sarabala1979