unquote strings from parameter-file #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
simster7
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Two very minor suggestions, but otherwise LGTM. I'll let @sarabala1979 take a look at this too and have him merge it in
Co-Authored-By: Simon Behar <simbeh7@gmail.com>
Co-Authored-By: Simon Behar <simbeh7@gmail.com>
|
The changes seem to be missing in the Is it going to be in |
|
Seems like it wasn't cherry-picked into the last release branch :( This will be in the next release. |
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a stab at attempting to unquote the strings from the parameters-file. See #1718.
I'm a complete Golang newb so style may be way off.