Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed debug Println #1741

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Removed debug Println #1741

merged 1 commit into from
Nov 6, 2019

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Nov 6, 2019

An fmt.Println(...) most likely for debug purposes got merged to master causing debug information to be printed to the user on the CLI:

$ argo submit --watch temp.yaml
[{steps1 stepsTempalte {[] []} nil []  nil  nil}]
[{steps2 stepsTempalte {[] []} nil []  nil  nil}]
[{leafA whalesay {[] []} nil []  nil  nil}]
[{leafB whalesay {[] []} nil []  nil  nil}]
[{steps1 stepsTempalte {[] []} nil []  nil  nil}]
[{steps2 stepsTempalte {[] []} nil []  nil  nil}]
[{leafA whalesay {[] []} nil []  nil  nil}]
[{leafB whalesay {[] []} nil []  nil  nil}]
Name:                suspend-template-nsv4n
Namespace:           argo
ServiceAccount:      default
Status:              Pending
Created:             Wed Nov 06 07:32:12 -0800 (now)
Name:                suspend-template-nsv4n
Namespace:           argo
ServiceAccount:      default
Status:              Pending
Created:             Wed Nov 06 07:32:12 -0800 (now)

As well as on the logs:

...
time="2019-11-06T15:32:03Z" level=info msg="Processing workflow" namespace=argo workflow=suspend-template-tvhrn
[{steps1 stepsTempalte {[] []} nil []  nil  nil}]
[{steps2 stepsTempalte {[] []} nil []  nil  nil}]
[{leafA whalesay {[] []} nil []  nil  nil}]
[{leafB whalesay {[] []} nil []  nil  nil}]
time="2019-11-06T15:32:03Z" level=info msg="Updating node &NodeStatus{ID:suspend-template-tvhrn-3894610589,Name:suspend-template-tvhrn[1].steps2[1].leafB.onExit,DisplayName:leafB.onExit,Type:Pod,TemplateName:exitContainer,TemplateRef:nil,Phase:Pending,BoundaryID:suspend-template-tvhrn-4142322267,Message:ContainerCreating,StartedAt:2019-11-06 15:31:59 +0000 UTC,FinishedAt:0001-01-01 00:00:00 +0000 UTC,PodIP:,Daemoned:nil,Inputs:nil,Outputs:nil,Children:[],OutboundNodes:[],StoredTemplateID:/exitContainer,WorkflowTemplateName:,OnExitNode:nil,} status Pending -> Running"
...

@sarabala1979 sarabala1979 merged commit f259244 into argoproj:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants