feat: Adds an Argo Server. Closes #1331 #1743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it xref #1331 ? |
|
yes |
|
Will this also support running workflows via this tool (I know argo-events have webhook gateway) or is it mostly "read-only". |
|
@hnykda You will also be able to run workflows via the API server |
|
Out of curiousity, is there any ETA on this feature? |
Fixed format and dependency issues
|
I'm really looking forward to this in the next update! |
|
We are working on it. v2.5 RC1 is planned on Jan 15. We will keep you
updated. Thanks
…On Wed, Dec 4, 2019 at 1:19 AM Shubham Koli (FaultyCarry) < ***@***.***> wrote:
I'm really looking forward to this next update!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1743>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AICWOVALQ43QODQDJF56GDLQW5YZ5ANCNFSM4JJ64F4Q>
.
--
Thanks & Regards
Saravanan
|
…into apiserverimpl
…into apiserverimpl
golangcibot
reviewed
Dec 19, 2019
| } | ||
| labels := wfReq.Workflow.GetLabels() | ||
| if labels == nil { | ||
| labels = make(map[string]string) |
There was a problem hiding this comment.
ineffectual assignment to labels (from ineffassign)
…into apiserverimpl
|
Closed in favor of #1882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1331