Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make kubectl print status and start/finished time #1766

Merged
merged 2 commits into from
Dec 4, 2019

Conversation

epa095
Copy link
Contributor

@epa095 epa095 commented Nov 14, 2019

Set additionalPrinterColumns in the CRD to make k8s print the status and age of workflows when using kubectl.
This required k8s >= 1.11.

Example of kubectl get workflows:

NAME                         STATUS      AGE
abc-87-1573741887810-4nhds   Succeeded   43m
abc-88-1573741887810-5t2p6   Running     43m
abc-89-1573741887810-77xq5   Running     43m
abc-90-1573741887810-7nd57   Failed      43m
abc-91-1573741887810-jlzzr   Succeeded   43m

Set additionalPrinterColumns in the CRD to make k8s print the status,
start-time and finished-time of workflows when using kubectl.
This required k8s >= 1.11.

Example of `kubectl get workflows`:

NAME                         STATUS      STARTED   FINISHED
abc-87-1573741887810-4nhds   Succeeded   43m       9m45s
abc-88-1573741887810-5t2p6   Running     43m
abc-89-1573741887810-77xq5   Running     43m
abc-90-1573741887810-7nd57   Failed      43m       22m
abc-91-1573741887810-jlzzr   Succeeded   43m       22m
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add, just need a quick change

manifests/base/crds/workflow-crd.yaml Outdated Show resolved Hide resolved
Removes Finished, and renames Started to Age
Copy link
Member

@simster7 simster7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let @sarabala1979 review and merge

@xianlubird
Copy link
Member

LGTM. Nice PR

@simster7 simster7 added this to the v2.4.3 milestone Dec 4, 2019
@simster7 simster7 merged commit 0e79edf into argoproj:master Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants