fix: Fix template scope #1836
Merged
fix: Fix template scope #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Dec 18, 2019
| @@ -1203,6 +1203,9 @@ func (woc *wfOperationCtx) executeTemplate(nodeName string, orgTmpl wfv1.Templat | |||
| return node, ErrDeadlineExceeded | |||
| } | |||
|
|
|||
| // Set templateScope from which the template resolution starts. | |||
| templateScope := tmplCtx.GetCurrentTemplateBase().GetTemplateScope() | |||
alexec
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TemplateScopeshould be a based template context from which a template resolution starts.This fix is necessary to make the workflow detail view work with workflow templates without steps: e.g.
examples/workflow-template/hello-world.yml