-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow retry strategy on non-leaf nodes, eg for step groups. Fixes #1891 #1892
Conversation
0bca8b6
to
2c30998
Compare
8ccd916
to
b89f339
Compare
Codecov Report
@@ Coverage Diff @@
## master #1892 +/- ##
=========================================
Coverage ? 11.43%
=========================================
Files ? 71
Lines ? 27903
Branches ? 0
=========================================
Hits ? 3192
Misses ? 24305
Partials ? 406
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking pretty good at the moment. Could you please look into writing some tests?
Sure - are there any specific scenarios you're thinking of other than the one I already created? |
@jessesuen do you want to review this one? Or at least provide commentary on the impact on removing this constraint? |
@mark9white I've tried to fix the conflict - but I think I've failed to do a good job - if you still want this - do you want to take a look? |
78b5ca4
to
ab2404a
Compare
ab2404a
to
a4f72b2
Compare
@alexec I've fixed the conflict |
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
. Why? for the release notes.Fixes #1891