Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not acquire lock in get_spot_instance_price(). #19

Merged
merged 1 commit into from
Aug 23, 2017
+7 −5
Merged

Do not acquire lock in get_spot_instance_price(). #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions platform/source/lib/ax/platform/minion_manager/cloud_provider/aws/aws_bid_advisor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,14 +277,16 @@ def get_on_demand_price(self, instance_type):
def get_spot_instance_price(self, instance_type, zone):
"""
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write a comment that caller needs to acquire a specific lock before making this call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Returns the spot-instance price for the given instance_type and zone.
Caller is *required* to acquire the lock.
"""
assert self.lock.locked(), "BidAdvisor lock not acquired"

# The spot price list is sorted by time. Find the latest instance
# for the zone and instance_type and use that as the spot price.
with self.lock:
for price_info in self.spot_price_list:
if price_info["InstanceType"] == instance_type and \
price_info["AvailabilityZone"] == zone:
return float(price_info["SpotPrice"])
for price_info in self.spot_price_list:
if price_info["InstanceType"] == instance_type and \
price_info["AvailabilityZone"] == zone:
return float(price_info["SpotPrice"])
return None

def get_new_bid(self, zone, instance_type):
Expand Down