fix: Make sql works for both mysql and postgre #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Jan 7, 2020
| )`, | ||
| `create unique index if not exists idx_name on ` + cfg.tableName + ` (name)`, |
There was a problem hiding this comment.
rather than modify the statement above - which will require manual migration for current users - can you just remove the if not exists and run that?
There was a problem hiding this comment.
Do you mean we already have public releases including database schema?
Codecov Report
@@ Coverage Diff @@
## apiserverimpl #1912 +/- ##
===============================================
Coverage ? 9.43%
===============================================
Files ? 50
Lines ? 30697
Branches ? 0
===============================================
Hits ? 2897
Misses ? 27417
Partials ? 383Continue to review full report at Codecov.
|
alexec
approved these changes
Jan 7, 2020
|
Merging as small change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mysql doesn't support to create an index with
if not exists.