feat: Add suspend and resume to CronWorkflows CLI #1925
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1925 +/- ##
=======================================
Coverage 10.65% 10.65%
=======================================
Files 35 35
Lines 24931 24931
=======================================
Hits 2657 2657
Misses 21935 21935
Partials 339 339Continue to review full report at Codecov.
|
|
@alexec Added tests! |
| When(). | ||
| CreateCronWorkflow(). | ||
| Then(). | ||
| RunCli([]string{"cron", "resume", "test-cron-wf-basic"}, func(t *testing.T, output string) { |
There was a problem hiding this comment.
Interesting... perhaps we can refactor the cli_test.go?
There was a problem hiding this comment.
Sure, however that is still only on the apiserverimpl branch. Maybe we can merge this, then I'll make the changes on that branch?
There was a problem hiding this comment.
ah - of course - we can merge from master into apiserverimpl
| @@ -55,3 +59,17 @@ func (t *Then) ExpectWorkflowList(listOptions metav1.ListOptions, block func(*te | |||
| block(t.t, wfList) | |||
| return t | |||
| } | |||
|
|
|||
| func (t *Then) RunCli(args []string, block func(*testing.T, string)) *Then { | |||
| cmd := exec.Command("../../../dist/argo", args...) | |||
There was a problem hiding this comment.
Can you please refactor the existing argo(...) command?
There was a problem hiding this comment.
Same as #1925 (comment)
|
Ignore e2e failure. |
Closes: #1924