Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added decompress in retry, resubmit and resume. #1934

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

sarabala1979
Copy link
Member

@sarabala1979 sarabala1979 commented Jan 10, 2020

Fixes #1933
Checklist:

@codecov
Copy link

codecov bot commented Jan 10, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@296dd0f). Click here to learn what that means.
The diff coverage is 21.54%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1934   +/-   ##
=========================================
  Coverage          ?   10.71%           
=========================================
  Files             ?       35           
  Lines             ?    25039           
  Branches          ?        0           
=========================================
  Hits              ?     2684           
  Misses            ?    22013           
  Partials          ?      342
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/generated.pb.go 0.45% <ø> (ø)
pkg/apis/workflow/v1alpha1/register.go 0% <0%> (ø)
...kg/apis/workflow/v1alpha1/zz_generated.deepcopy.go 0% <0%> (ø)
workflow/common/util.go 3.13% <0%> (ø)
workflow/validate/lint.go 0% <0%> (ø)
pkg/apis/workflow/v1alpha1/openapi_generated.go 0% <0%> (ø)
workflow/config/config.go 100% <100%> (ø)
workflow/common/placeholder.go 100% <100%> (ø)
workflow/controller/workflowpod.go 72.67% <100%> (ø)
workflow/validate/validate.go 75.15% <28.57%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 296dd0f...11b6d30. Read the comment docs.

@sarabala1979 sarabala1979 merged commit f69655a into argoproj:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing workflow decompress in retry, resume and resubmit cli commands
2 participants