Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add quick start manifests to Git. Change auth-mode to default to server. Fixes #1990 #1993

Merged
merged 8 commits into from
Jan 16, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 15, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #1993 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1993   +/-   ##
======================================
  Coverage    8.88%   8.88%           
======================================
  Files          53      53           
  Lines       33611   33611           
======================================
  Hits         2986    2986           
  Misses      30234   30234           
  Partials      391     391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc656b1...6a859e6. Read the comment docs.

@alexec alexec added this to the v2.5 milestone Jan 16, 2020
@alexec alexec marked this pull request as ready for review January 16, 2020 01:44
@alexec alexec requested a review from jessesuen January 16, 2020 01:44
@alexec alexec changed the title feat: Add quick start manifests to Git. Fixes #1990 feat: Add quick start manifests to Git. Change auth-mode to default to server. Fixes #1990 Jan 16, 2020
@alexec alexec merged commit ed36d92 into argoproj:master Jan 16, 2020
@alexec alexec deleted the quick-start branch January 16, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants