Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Encourage users to upvote issues relevant to them #1996

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

simster7
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@simster7 simster7 requested a review from alexec January 16, 2020 02:37
@codecov
Copy link

codecov bot commented Jan 16, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1a777cc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1996   +/-   ##
========================================
  Coverage          ?   8.87%           
========================================
  Files             ?      53           
  Lines             ?   33650           
  Branches          ?       0           
========================================
  Hits              ?    2986           
  Misses            ?   30273           
  Partials          ?     391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a777cc...9959238. Read the comment docs.

@simster7 simster7 merged commit d1965c9 into argoproj:master Jan 16, 2020
@simster7 simster7 deleted the thumbs branch January 16, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants