-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auth refactoring to support single version token #1998
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1998 +/- ##
=========================================
+ Coverage 8.86% 8.88% +0.02%
=========================================
Files 52 52
Lines 33562 33585 +23
=========================================
+ Hits 2974 2985 +11
- Misses 30195 30205 +10
- Partials 393 395 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Conditional approval - can you look at my comments please? Otherwise - great stuff!
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
. Refactoring Auth implementation to support single token format #1997