Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Auth refactoring to support single version token #1998

Merged
merged 18 commits into from
Jan 21, 2020

Conversation

sarabala1979
Copy link
Member

@sarabala1979 sarabala1979 commented Jan 16, 2020

Checklist:

  • [ x] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • [ x] The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". Refactoring Auth implementation to support single token format #1997
  • [x ] I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

Merging #1998 into master will increase coverage by 0.02%.
The diff coverage is 36.76%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1998      +/-   ##
=========================================
+ Coverage    8.86%   8.88%   +0.02%     
=========================================
  Files          52      52              
  Lines       33562   33585      +23     
=========================================
+ Hits         2974    2985      +11     
- Misses      30195   30205      +10     
- Partials      393     395       +2
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 7.23% <ø> (ø) ⬆️
.../apis/workflow/v1alpha1/workflow_template_types.go 46.15% <ø> (ø) ⬆️
pkg/apis/workflow/v1alpha1/openapi_generated.go 0% <0%> (ø) ⬆️
workflow/util/util.go 16.04% <0%> (ø) ⬆️
...kg/apis/workflow/v1alpha1/zz_generated.deepcopy.go 0% <0%> (ø) ⬆️
util/kubeconfig/kubeconfig.go 10.71% <0%> (ø) ⬆️
pkg/apis/workflow/v1alpha1/generated.pb.go 0.45% <0%> (ø) ⬆️
workflow/controller/operator.go 57.54% <100%> (ø) ⬆️
workflow/ttlcontroller/ttlcontroller.go 32.35% <100%> (ø) ⬆️
workflow/controller/controller.go 0.71% <40%> (+0.71%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de02a42...93dbb00. Read the comment docs.

@sarabala1979 sarabala1979 added type/feature Feature request type/security Security related labels Jan 19, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval - can you look at my comments please? Otherwise - great stuff!

cmd/argo/commands/client/conn.go Outdated Show resolved Hide resolved
test/e2e/argo_server_test.go Show resolved Hide resolved
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
test/e2e/argo_server_test.go Show resolved Hide resolved
test/e2e/cli_test.go Outdated Show resolved Hide resolved
test/e2e/fixtures/util.go Outdated Show resolved Hide resolved
util/kubeconfig/kubeconfig.go Show resolved Hide resolved
util/kubeconfig/token.go Show resolved Hide resolved
util/kubeconfig/token_test.go Show resolved Hide resolved
util/kubeconfig/token_test.go Show resolved Hide resolved
test/e2e/cli_test.go Outdated Show resolved Hide resolved
test/e2e/fixtures/env.go Outdated Show resolved Hide resolved
@sarabala1979 sarabala1979 merged commit f8569ae into argoproj:master Jan 21, 2020
@sarabala1979 sarabala1979 deleted the AuthRefactor branch January 21, 2020 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request type/security Security related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants