-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ability to submit CronWorkflow from CLI #2003
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2003 +/- ##
======================================
Coverage 11.7% 11.7%
======================================
Files 52 52
Lines 26313 26313
======================================
Hits 3081 3081
Misses 22837 22837
Partials 395 395 Continue to review full report at Codecov.
|
I'd like to review this, but it is not on the project board, so it has not been prioritized :( |
@alexec Added to the review board |
@jessesuen is this high priority? |
I think it should certainly be included with the next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes requested, including two moderately sized one.
You'll need to git merge master
before you can merge.
@@ -61,6 +78,7 @@ func NewSubmitCommand() *cobra.Command { | |||
command.Flags().Int32Var(&priority, "priority", 0, "workflow priority") | |||
command.Flags().StringVarP(&submitOpts.ParameterFile, "parameter-file", "f", "", "pass a file containing all input parameters") | |||
command.Flags().StringVarP(&submitOpts.Labels, "labels", "l", "", "Comma separated labels to apply to the workflow. Will override previous values.") | |||
command.Flags().StringVar(&from, "from", "", "Submit from an existing `kind/name` E.g., --from=cronwf/hello-world-cwf") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
used of back ticks makes for nice help:
submit a workflow
Usage:
argo submit [FILE... | --from `kind/name] [flags]
Examples:
# Submit multiple workflows from files:
argo submit my-wf.yaml
# Submit a single workflow from an existing resource
argo submit --from cronwf/my-cron-wf
Flags:
--dry-run modify the workflow on the client-side without creating it
--entrypoint string override entrypoint
--from kind/name Submit from an existing kind/name E.g., --from=cronwf/hello-world-cwf
--generate-name string override metadata.generateName
-h, --help help for submit
--instanceid string submit with a specific controller's instance id label
-l, --labels string Comma separated labels to apply to the workflow. Will override previous values.
--name string override metadata.name
-o, --output string Output format. One of: name|json|yaml|wide
-p, --parameter stringArray pass an input parameter
-f, --parameter-file string pass a file containing all input parameters
--priority int32 workflow priority
--server-dry-run send request to server with dry-run flag which will modify the workflow without creating it
--serviceaccount string run all pods in the workflow using specified serviceaccount
--strict perform strict workflow validation (default true)
-w, --wait wait for the workflow to complete
--watch watch the workflow until it completes
…. Closes #1963
Examples:
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.