Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixed grammar on TTLStrategy #2006

Merged
merged 1 commit into from
Jan 17, 2020
Merged

fix: Fixed grammar on TTLStrategy #2006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/openapi-spec/swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1201,11 +1201,11 @@
"description": "TTLStrategy is the strategy for the time to live depending on if the workflow succeded or failed",
"type": "object",
"properties": {
"secondsAfterCompleted": {
"secondsAfterCompletion": {
"type": "integer",
"format": "int32"
},
"secondsAfterFailed": {
"secondsAfterFailure": {
"type": "integer",
"format": "int32"
},
Expand Down Expand Up @@ -1763,7 +1763,7 @@
"x-kubernetes-patch-strategy": "merge"
},
"ttlSecondsAfterFinished": {
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution (Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be deleted after ttlSecondsAfterFinished expires. If this field is unset, ttlSecondsAfterFinished will not expire. If this field is set to zero, ttlSecondsAfterFinished expires immediately after the Workflow finishes. DEPRECATED: Use TTLStrategy.SecondsAfterCompleted instead.",
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution (Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be deleted after ttlSecondsAfterFinished expires. If this field is unset, ttlSecondsAfterFinished will not expire. If this field is set to zero, ttlSecondsAfterFinished expires immediately after the Workflow finishes. DEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead.",
"type": "integer",
"format": "int32"
},
Expand Down
6 changes: 3 additions & 3 deletions cmd/server/cronworkflow/cron-workflow.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3598,15 +3598,15 @@
"v1alpha1TTLStrategy": {
"type": "object",
"properties": {
"secondsAfterCompleted": {
"secondsAfterCompletion": {
"type": "integer",
"format": "int32"
},
"secondsAfterSuccess": {
"type": "integer",
"format": "int32"
},
"secondsAfterFailed": {
"secondsAfterFailure": {
"type": "integer",
"format": "int32"
}
Expand Down Expand Up @@ -3940,7 +3940,7 @@
"ttlSecondsAfterFinished": {
"type": "integer",
"format": "int32",
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution\n(Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be\ndeleted after ttlSecondsAfterFinished expires. If this field is unset,\nttlSecondsAfterFinished will not expire. If this field is set to zero,\nttlSecondsAfterFinished expires immediately after the Workflow finishes.\nDEPRECATED: Use TTLStrategy.SecondsAfterCompleted instead."
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution\n(Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be\ndeleted after ttlSecondsAfterFinished expires. If this field is unset,\nttlSecondsAfterFinished will not expire. If this field is set to zero,\nttlSecondsAfterFinished expires immediately after the Workflow finishes.\nDEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead."
},
"ttlStrategy": {
"$ref": "#/definitions/v1alpha1TTLStrategy",
Expand Down
6 changes: 3 additions & 3 deletions cmd/server/workflow/workflow.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3905,15 +3905,15 @@
"v1alpha1TTLStrategy": {
"type": "object",
"properties": {
"secondsAfterCompleted": {
"secondsAfterCompletion": {
"type": "integer",
"format": "int32"
},
"secondsAfterSuccess": {
"type": "integer",
"format": "int32"
},
"secondsAfterFailed": {
"secondsAfterFailure": {
"type": "integer",
"format": "int32"
}
Expand Down Expand Up @@ -4277,7 +4277,7 @@
"ttlSecondsAfterFinished": {
"type": "integer",
"format": "int32",
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution\n(Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be\ndeleted after ttlSecondsAfterFinished expires. If this field is unset,\nttlSecondsAfterFinished will not expire. If this field is set to zero,\nttlSecondsAfterFinished expires immediately after the Workflow finishes.\nDEPRECATED: Use TTLStrategy.SecondsAfterCompleted instead."
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution\n(Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be\ndeleted after ttlSecondsAfterFinished expires. If this field is unset,\nttlSecondsAfterFinished will not expire. If this field is set to zero,\nttlSecondsAfterFinished expires immediately after the Workflow finishes.\nDEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead."
},
"ttlStrategy": {
"$ref": "#/definitions/v1alpha1TTLStrategy",
Expand Down
6 changes: 3 additions & 3 deletions cmd/server/workflowarchive/workflow-archive.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3235,15 +3235,15 @@
"v1alpha1TTLStrategy": {
"type": "object",
"properties": {
"secondsAfterCompleted": {
"secondsAfterCompletion": {
"type": "integer",
"format": "int32"
},
"secondsAfterSuccess": {
"type": "integer",
"format": "int32"
},
"secondsAfterFailed": {
"secondsAfterFailure": {
"type": "integer",
"format": "int32"
}
Expand Down Expand Up @@ -3607,7 +3607,7 @@
"ttlSecondsAfterFinished": {
"type": "integer",
"format": "int32",
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution\n(Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be\ndeleted after ttlSecondsAfterFinished expires. If this field is unset,\nttlSecondsAfterFinished will not expire. If this field is set to zero,\nttlSecondsAfterFinished expires immediately after the Workflow finishes.\nDEPRECATED: Use TTLStrategy.SecondsAfterCompleted instead."
"description": "TTLSecondsAfterFinished limits the lifetime of a Workflow that has finished execution\n(Succeeded, Failed, Error). If this field is set, once the Workflow finishes, it will be\ndeleted after ttlSecondsAfterFinished expires. If this field is unset,\nttlSecondsAfterFinished will not expire. If this field is set to zero,\nttlSecondsAfterFinished expires immediately after the Workflow finishes.\nDEPRECATED: Use TTLStrategy.SecondsAfterCompletion instead."
},
"ttlStrategy": {
"$ref": "#/definitions/v1alpha1TTLStrategy",
Expand Down
8 changes: 4 additions & 4 deletions examples/gc-ttl.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ kind: Workflow
metadata:
generateName: gc-ttl-
spec:
TTLStrategy:
secondsAfterCompleted: 10 # Time to live after workflow is completed, replaces ttlSecondsAfterFinished
secondsAfterSuccess: 5 # Time to live after workflow is successful
secondsAfterFailed: 5 # Time to live after workflow fails
ttlStrategy:
secondsAfterCompletion: 10 # Time to live after workflow is completed, replaces ttlSecondsAfterFinished
secondsAfterSuccess: 5 # Time to live after workflow is successful
secondsAfterFailure: 5 # Time to live after workflow fails
entrypoint: whalesay
templates:
- name: whalesay
Expand Down
Loading