Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixes the test job on master #2008

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 17, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Jan 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@29c8507). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2008   +/-   ##
========================================
  Coverage          ?   8.87%           
========================================
  Files             ?      53           
  Lines             ?   33650           
  Branches          ?       0           
========================================
  Hits              ?    2986           
  Misses            ?   30273           
  Partials          ?     391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29c8507...7cc1773. Read the comment docs.

@alexec alexec marked this pull request as ready for review January 17, 2020 01:36
@@ -11,7 +11,7 @@ export DOCKER_BUILDKIT = 1
# docker image publishing options
IMAGE_NAMESPACE ?= argoproj
ifeq ($(GIT_BRANCH),master)
VERSION := latest
VERSION := $(shell cat VERSION)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current Master branch version file contains the next release version like 2.5.0. are you thing to change version file in master branch to latest or master ?

@alexec alexec merged commit 5868982 into argoproj:master Jan 17, 2020
@alexec alexec deleted the fix-master branch January 17, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants