Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow workflow-level parameters to be modified in the UI when submitting a workflow #2030

Merged
merged 9 commits into from
Jan 23, 2020

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Jan 21, 2020

Closes #1999

Demo: https://cl.ly/71d0d4350627

Still WIP

@simster7 simster7 marked this pull request as ready for review January 22, 2020 16:51
@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@4941b32). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2030   +/-   ##
========================================
  Coverage          ?    8.9%           
========================================
  Files             ?      53           
  Lines             ?   33676           
  Branches          ?       0           
========================================
  Hits              ?    3000           
  Misses            ?   30282           
  Partials          ?     394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4941b32...efab6ed. Read the comment docs.

@simster7 simster7 requested a review from alexec January 23, 2020 17:11
@simster7 simster7 merged commit c46c683 into argoproj:master Jan 23, 2020
@simster7 simster7 deleted the params2 branch January 23, 2020 17:41
@nicorikken
Copy link

@simster7 ❤️ thanks, a simple but welcome improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI for providing input parameters to a (templated) workflow
3 participants