fix(archive): upsert archive + ci: Pin images on CI, add readiness probes, clean-up logging and other tweaks #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
========================================
Coverage ? 8.78%
========================================
Files ? 61
Lines ? 34575
Branches ? 0
========================================
Hits ? 3036
Misses ? 31148
Partials ? 391
Continue to review full report at Codecov.
|
golangcibot
reviewed
Jan 22, 2020
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
golangcibot
reviewed
Jan 22, 2020
alexec
commented
Jan 23, 2020
| @@ -69,7 +69,33 @@ func (r *workflowArchive) ArchiveWorkflow(wf *wfv1.Workflow) error { | |||
| }, | |||
| Workflow: string(workflow), | |||
| }) | |||
| return err | |||
| if err != nil { | |||
| if isDuplicateKeyError(err) { | |||
There was a problem hiding this comment.
this is an actual code change
alexec
commented
Jan 23, 2020
| @@ -73,13 +73,25 @@ func (s *E2ESuite) TearDownSuite() { | |||
| func (s *E2ESuite) BeforeTest(_, _ string) { | |||
| s.Diagnostics = &Diagnostics{} | |||
|
|
|||
| // delete all cron workflows | |||
| cronList, err := s.cronClient.List(metav1.ListOptions{LabelSelector: label}) | |||
There was a problem hiding this comment.
let deletes crons before workflows, in case one get scheduled
alexec
changed the title
alexec
commented
Jan 23, 2020
| @@ -63,6 +62,12 @@ func (g *Given) Workflow(text string) *Given { | |||
| g.t.Fatal(err) | |||
| } | |||
| } | |||
| if g.wf.GetLabels() == nil { | |||
There was a problem hiding this comment.
not all wfs were getting labelled - this fixes that
alexec
commented
Jan 23, 2020
| @@ -566,7 +566,7 @@ func (s *ArgoServerSuite) TestArtifactServer() { | |||
| Expect(). | |||
| Status(200). | |||
| Body(). | |||
| Contains("😀 Hello Argo!") | |||
| Contains(":) Hello Argo!") | |||
There was a problem hiding this comment.
MySQL does not appear to have good emoticon support
alexec
changed the title
simster7
approved these changes
Jan 23, 2020
| @@ -73,13 +73,25 @@ func (s *E2ESuite) TearDownSuite() { | |||
| func (s *E2ESuite) BeforeTest(_, _ string) { | |||
| s.Diagnostics = &Diagnostics{} | |||
|
|
|||
| // delete all cron workflows | |||
| cronList, err := s.cronClient.List(metav1.ListOptions{LabelSelector: label}) | |||
| @@ -48,7 +48,7 @@ func (s *SmokeSuite) TestWorkflowTemplateBasic() { | |||
| When(). | |||
| CreateWorkflowTemplates(). | |||
| SubmitWorkflow(). | |||
| WaitForWorkflow(30 * time.Second). | |||
| WaitForWorkflow(60 * time.Second). | |||
There was a problem hiding this comment.
If we're increasing the time here we should make sure we are also increasing it on the Makefile (go test ...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".