Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Makefile): Rename staticfiles make target. Fixes #2010 #2040

Merged
merged 2 commits into from
Jan 23, 2020
Merged

fix(Makefile): Rename staticfiles make target. Fixes #2010 #2040

merged 2 commits into from
Jan 23, 2020

Conversation

dtaniwaki
Copy link
Member

Fixes #2010

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@dtaniwaki dtaniwaki changed the title fix(Makefile): Rename staticfiles make target Fixes #2010 fix(Makefile): Rename staticfiles make target Fixes. #2010 Jan 23, 2020
@dtaniwaki dtaniwaki requested a review from alexec January 23, 2020 03:40
@alexec
Copy link
Contributor

alexec commented Jan 23, 2020

What about using ‘$(HOME)/go/bin?

@alexec alexec closed this Jan 23, 2020
@alexec alexec reopened this Jan 23, 2020
@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@1a96007). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2040   +/-   ##
========================================
  Coverage          ?   8.78%           
========================================
  Files             ?      61           
  Lines             ?   34557           
  Branches          ?       0           
========================================
  Hits              ?    3036           
  Misses            ?   31130           
  Partials          ?     391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a96007...c2a2c14. Read the comment docs.

@dtaniwaki dtaniwaki changed the title fix(Makefile): Rename staticfiles make target Fixes. #2010 fix(Makefile): Rename staticfiles make target. Fixes #2010 Jan 23, 2020
@dtaniwaki
Copy link
Member Author

What about using ‘$(HOME)/go/bin?

Do we have to use an actual file name as the make target? The make target installs staticfiles in your GOPATH. I think the target name has nothing to do with the environment.

Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal of the task was to take advantage of the Makefile to install the tool, based on this blog post that installed gometalinter in the same way.

https://sahilm.com/makefiles-for-golang/

But I don't feel very strongly about this particular target - as Go is pretty snappy installing this, so I'll approve.

@alexec alexec merged commit faa9dbb into argoproj:master Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make is broken
2 participants