-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade prometheus client_golang. Fixes #1983 #2052
fix: upgrade prometheus client_golang. Fixes #1983 #2052
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2052 +/- ##
======================================
Coverage 8.78% 8.78%
======================================
Files 61 61
Lines 34584 34584
======================================
Hits 3037 3037
Misses 31156 31156
Partials 391 391 Continue to review full report at Codecov.
|
6f9bb95
to
4f0fe4b
Compare
Hi @fscnick could you please tell me a bit about why we need to upgrade that library? It's not clear from your issue |
If prometheus client with v1.0.0 or higher version is used in a program and also some argo package has been included. That caused an compilation error because the higher version would be taken. However, it has different input arguments. Or there is other consideration. |
Will consider this PR after merging #1853 |
registry.MustRegister(prometheus.NewProcessCollector(prometheus.ProcessCollectorOpts{ | ||
PidFn: func() (int, error) { return os.Getpid(), nil }, | ||
Namespace: "", | ||
ReportErrors: true, | ||
})) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Making a comment here so I can link to this code]
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.Fixes #1983