Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade prometheus client_golang. Fixes #1983 #2052

Closed

Conversation

fscnick
Copy link

@fscnick fscnick commented Jan 24, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

Fixes #1983

@claassistantio
Copy link

claassistantio commented Jan 24, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #2052 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2052   +/-   ##
======================================
  Coverage    8.78%   8.78%           
======================================
  Files          61      61           
  Lines       34584   34584           
======================================
  Hits         3037    3037           
  Misses      31156   31156           
  Partials      391     391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0fe4b...70673cb. Read the comment docs.

@fscnick fscnick force-pushed the feature/upgrade-prometheus-client branch from 6f9bb95 to 4f0fe4b Compare January 25, 2020 07:40
@fscnick fscnick requested a review from alexec January 25, 2020 08:16
@simster7
Copy link
Member

Hi @fscnick could you please tell me a bit about why we need to upgrade that library? It's not clear from your issue

@fscnick
Copy link
Author

fscnick commented Jan 28, 2020

If prometheus client with v1.0.0 or higher version is used in a program and also some argo package has been included. That caused an compilation error because the higher version would be taken. However, it has different input arguments. Or there is other consideration.

@simster7
Copy link
Member

Will consider this PR after merging #1853

Comment on lines +72 to +76
registry.MustRegister(prometheus.NewProcessCollector(prometheus.ProcessCollectorOpts{
PidFn: func() (int, error) { return os.Getpid(), nil },
Namespace: "",
ReportErrors: true,
}))
Copy link
Member

@simster7 simster7 Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Making a comment here so I can link to this code]

@simster7
Copy link
Member

@fscnick Seems like we're going to upgrade the client in #2097 along with Go 1.13. I'll be closing this for now, but thanks for submitting this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import Argo client library but build failed.
3 participants