Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move server code (cmd/server/ -> server/) #2071

Merged
merged 3 commits into from
Jan 27, 2020
Merged

refactor: Move server code (cmd/server/ -> server/) #2071

merged 3 commits into from
Jan 27, 2020

Conversation

simster7
Copy link
Member

Closes #1947

@simster7 simster7 requested a review from alexec January 27, 2020 17:17
alexec
alexec approved these changes Jan 27, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional approval - please run make lint which should fix your go imports.

@codecov
Copy link

codecov bot commented Jan 27, 2020 •
edited
Loading

Codecov Report

Merging #2071 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2071   +/-   ##
======================================
  Coverage    8.78%   8.78%           
======================================
  Files          61      61           
  Lines       34584   34584           
======================================
  Hits         3037    3037           
  Misses      31156   31156           
  Partials      391     391

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bab872...57458e2. Read the comment docs.

@simster7 simster7 merged commit c4f49cf into argoproj:master Jan 27, 2020
@simster7 simster7 deleted the server-refactor branch January 27, 2020 18:20
alexec pushed a commit to alexec/argo-workflows that referenced this pull request Jan 27, 2020
@simster7 @alexec
refactor: Move server code (cmd/server/ -> server/) (argoproj#2071)
41f6030
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move server code out of cmd/ folder
2 participants
@simster7 @alexec