Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(security): properly authorize list archived workflows #2079

Merged
merged 4 commits into from
Jan 28, 2020
Merged

fix(security): properly authorize list archived workflows #2079

merged 4 commits into from
Jan 28, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Jan 28, 2020 •
edited by agilgur5
Loading

Fixes #2049

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@alexec alexec requested a review from whynowy January 28, 2020 00:53
@alexec alexec added this to the v2.5 milestone Jan 28, 2020
@codecov

This comment was marked as resolved.

Sign in to view
@alexec alexec marked this pull request as ready for review January 28, 2020 01:29
whynowy
whynowy reviewed Jan 28, 2020
View reviewed changes
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
test/e2e/argo_server_test.go Outdated Show resolved Hide resolved
@alexec alexec requested a review from whynowy January 28, 2020 18:30
whynowy
whynowy approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexec alexec merged commit b97044d into argoproj:master Jan 28, 2020
@alexec alexec deleted the fix-perm branch January 28, 2020 19:14
@agilgur5 agilgur5 added type/security Security related area/api Argo Server API labels Sep 8, 2024
@agilgur5 agilgur5 changed the title fix(security): Fixes an issue that allowed you to list archived workf… fix(security): properly authorize list archived workfows Sep 8, 2024
@agilgur5 agilgur5 changed the title fix(security): properly authorize list archived workfows fix(security): properly authorize list archived workflows Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

Assignees
No one assigned
Labels
area/api Argo Server API type/security Security related
Projects
None yet
Milestone
v2.5
Development

Successfully merging this pull request may close these issues.

Lack of permission check when listing archived workflows
3 participants
@alexec @whynowy @agilgur5