build: adds make env to make testing easier
#2087
Conversation
| @@ -30,6 +30,7 @@ STATIC_BUILD ?= true | |||
| CI ?= false | |||
| DB ?= postgres | |||
| K3D := $(shell if [ "`kubectl config current-context`" = "k3s-default" ]; then echo true; else echo false; fi) | |||
| ARGO_TOKEN = $(shell kubectl -n argo get secret -o name | grep argo-server | xargs kubectl -n argo get -o jsonpath='{.data.token}' | base64 --decode) | |||
There was a problem hiding this comment.
there are big differences between :=, ?= and = in Makefiles
There was a problem hiding this comment.
kubectl -nargo get sa argo-server -o jsonpath='{.secrets[0].name}' | xargs kubectl -n argo get secret -o jsonpath='{.data.token}' | base64 --decode might be more accurate, but this is okay.
Codecov Report
@@ Coverage Diff @@
## master #2087 +/- ##
======================================
Coverage 8.89% 8.89%
======================================
Files 61 61
Lines 34597 34597
======================================
Hits 3077 3077
Misses 31132 31132
Partials 388 388Continue to review full report at Codecov.
|
| @@ -30,6 +30,7 @@ STATIC_BUILD ?= true | |||
| CI ?= false | |||
| DB ?= postgres | |||
| K3D := $(shell if [ "`kubectl config current-context`" = "k3s-default" ]; then echo true; else echo false; fi) | |||
| ARGO_TOKEN = $(shell kubectl -n argo get secret -o name | grep argo-server | xargs kubectl -n argo get -o jsonpath='{.data.token}' | base64 --decode) | |||
There was a problem hiding this comment.
kubectl -nargo get sa argo-server -o jsonpath='{.secrets[0].name}' | xargs kubectl -n argo get secret -o jsonpath='{.data.token}' | base64 --decode might be more accurate, but this is okay.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".