feat: support arg --token when talking to argo-server (#2027) #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexec
reviewed
Jan 28, 2020
alexec
reviewed
Jan 29, 2020
| @@ -42,6 +42,26 @@ func (s *CLISuite) TestToken() { | |||
| }) | |||
| } | |||
|
|
|||
| func (s *CLISuite) TestTokenArg() { | |||
whynowy
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2089 +/- ##
=========================================
+ Coverage 8.89% 8.89% +<.01%
=========================================
Files 61 61
Lines 34597 34597
=========================================
+ Hits 3077 3079 +2
+ Misses 31132 31131 -1
+ Partials 388 387 -1
Continue to review full report at Codecov.
|
whynowy
changed the title
golangcibot
reviewed
Jan 29, 2020
|
@alexec - Do you mind reviewing it again since some changes happened since your approval. |
alexec
reviewed
Jan 29, 2020
This reverts commit 0ecd00d68bafd83679c7162973af56e70b291cca.
alexec
reviewed
Jan 29, 2020
| @@ -40,13 +40,14 @@ func GetRestConfig(token string) (*restclient.Config, error) { | |||
| // convert the REST config into a bearer token | |||
| func GetBearerToken(in *restclient.Config) (string, error) { | |||
|
|
|||
| if len(in.BearerToken) > 0 { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
"fix(controller): Updates such and such. Fixes #1234".