Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented Basic Auth scheme #2093

Merged
merged 19 commits into from
Jan 30, 2020

Conversation

sarabala1979
Copy link
Member

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". Support basic Authentication in Argo CLI to API Server #2020
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@sarabala1979 sarabala1979 changed the title Implemented Basic Auth scheme feat: Implemented Basic Auth scheme Jan 29, 2020
util/kubeconfig/kubeconfig_test.go Outdated Show resolved Hide resolved
util/kubeconfig/kubeconfig_test.go Show resolved Hide resolved
util/kubeconfig/kubeconfig_test.go Show resolved Hide resolved
util/kubeconfig/kubeconfig_test.go Outdated Show resolved Hide resolved
@alexec alexec self-assigned this Jan 29, 2020
@alexec
Copy link
Contributor

alexec commented Jan 29, 2020

@sarabala1979 let me know when you want me to review this.

@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #2093 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2093   +/-   ##
======================================
  Coverage    9.02%   9.02%           
======================================
  Files          61      61           
  Lines       34645   34645           
======================================
  Hits         3127    3127           
  Misses      31124   31124           
  Partials      394     394

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20ea901...8f23cf3. Read the comment docs.

test/e2e/cli_test.go Outdated Show resolved Hide resolved
util/kubeconfig/kubeconfig.go Outdated Show resolved Hide resolved
cmd/argo/commands/client/conn.go Outdated Show resolved Hide resolved
sarabala1979 and others added 3 commits January 29, 2020 19:39
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@sarabala1979
Copy link
Member Author

@alexec can you review it?

@alexec alexec added this to the v2.5 milestone Jan 30, 2020
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One query about an if/else in a test.

test/e2e/cli_test.go Show resolved Hide resolved
@sarabala1979 sarabala1979 merged commit 7a19f85 into argoproj:master Jan 30, 2020
@sarabala1979 sarabala1979 deleted the basicauth branch January 30, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants