-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implemented Basic Auth scheme #2093
Conversation
@sarabala1979 let me know when you want me to review this. |
Codecov Report
@@ Coverage Diff @@
## master #2093 +/- ##
======================================
Coverage 9.02% 9.02%
======================================
Files 61 61
Lines 34645 34645
======================================
Hits 3127 3127
Misses 31124 31124
Partials 394 394 Continue to review full report at Codecov.
|
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@alexec can you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One query about an if/else in a test.
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
. Support basic Authentication in Argo CLI to API Server #2020