Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: container ID parser in PNS executor for CRI-O. Fixes #2095 #2096

Merged
merged 3 commits into from
Jan 30, 2020
Merged

fix: container ID parser in PNS executor for CRI-O. Fixes #2095 #2096

merged 3 commits into from
Jan 30, 2020

Conversation

rafalbigaj
Copy link
Contributor

@rafalbigaj rafalbigaj commented Jan 29, 2020 •
edited
Loading

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@claassistantio
Copy link

claassistantio commented Jan 29, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rafalbigaj rafalbigaj mentioned this pull request Jan 29, 2020
Closed
4 tasks
@rafalbigaj rafalbigaj changed the title Parse container ID in correct way on CRI-O. Fixes #2095 fix: container ID parser in PNS executor for CRI-O. Fixes #2095 Jan 29, 2020
@alexec alexec self-assigned this Jan 29, 2020
alexec
alexec approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alexec alexec merged commit aece7e6 into argoproj:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen

Assignees

@alexec alexec

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafalbigaj @claassistantio @alexec