Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip running --token testing if it is not on CI #2104

Merged
merged 1 commit into from
Jan 30, 2020

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Jan 30, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I have written unit and/or e2e tests for my change. PRs without these are unlike to be merged.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@aece7e6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #2104   +/-   ##
========================================
  Coverage          ?   8.89%           
========================================
  Files             ?      61           
  Lines             ?   34597           
  Branches          ?       0           
========================================
  Hits              ?    3079           
  Misses            ?   31131           
  Partials          ?     387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aece7e6...16eca66. Read the comment docs.

@whynowy whynowy requested a review from alexec January 30, 2020 19:29
@whynowy whynowy merged commit 16aed5c into argoproj:master Jan 30, 2020
@whynowy whynowy deleted the noci branch January 30, 2020 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants