Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable webpack dot rule #2112

Merged
merged 1 commit into from
Jan 31, 2020
Merged

fix: Disable webpack dot rule #2112

merged 1 commit into from
Jan 31, 2020

Conversation

simster7
Copy link
Member

Fixes: #2103

Same problem and fix as argoproj/argo-cd#2114 and argoproj/argo-cd#2162

@codecov
Copy link

codecov bot commented Jan 31, 2020

Codecov Report

Merging #2112 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2112   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          52       52           
  Lines       26353    26353           
=======================================
  Hits         3081     3081           
  Misses      22877    22877           
  Partials      395      395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865b4f3...bc6d184. Read the comment docs.

@alexec alexec merged commit b2bd25b into argoproj:master Jan 31, 2020
@tcolgate
Copy link
Contributor

tcolgate commented Feb 3, 2020

@simster7 I've updated to rc7, but this doesn't sseem to have resolved the problem for me.

@tcolgate
Copy link
Contributor

tcolgate commented Feb 3, 2020

I think the static file serving from the go process negates this fix:
https://github.com/argoproj/argo/blob/master/server/static/static.go#L20-L22

@tcolgate
Copy link
Contributor

tcolgate commented Feb 3, 2020

It may be a better option to use staticfiles Hash method to check if the file exists, and if it doesn't, pass the request on (rather than using the dot check.

@tcolgate
Copy link
Contributor

tcolgate commented Feb 3, 2020

something like #2134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deep links to workflows, and reload, no longer work
3 participants